[Top] [All Lists]

Re: [PATCH] sanity check attr fork size

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] sanity check attr fork size
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 5 Jan 2009 09:40:11 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090104164211.GA15734@xxxxxxxxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <20090104164211.GA15734@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Sun, Jan 04, 2009 at 11:42:11AM -0500, Christoph Hellwig wrote:
> Recently we have quite a few kerneloops reports about dereferencing a NULL
> if_data in the attribute fork.  From looking over the code this can only
> happen if we pass a 0 size argument to xfs_iformat_local.  This implies some
> sort of corruption and in fact the only mailinglist report about this from
> earlier this year was after a powerfail presumably on a system with write
> cache and without barriers.
> Add a quick sanity check for the attr fork size in xfs_iformat to catch
> these early and without an oops.

Looks sane to me.

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>