[Top] [All Lists]

Re: [PATCH, RFC] xfs_repair: allow filesystems with a single AG

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH, RFC] xfs_repair: allow filesystems with a single AG
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sun, 4 Jan 2009 11:48:35 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <4953C8B8.4010500@xxxxxxxxxxx>
References: <20081224231901.GA652@xxxxxxxxxxxxx> <4953C8B8.4010500@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Dec 25, 2008 at 11:54:00AM -0600, Eric Sandeen wrote:
> Christoph Hellwig wrote:
> > Currently xfs_repair bails out on a filesystem with just a single AG.
> > But that's a perfectly valid configureation, so we should allow it.
> > 
> > Skip the geomery validation because we simply can't do it if we don't
> > have a secondary SB, and make sure to take the internal log into account
> > when guestimating the first inode cluster.
> > 
> > I'll also cook up a testcase for repair on single AG filesystems.
> While I think we should certainly allow this, what's the worst-case
> scenario for a corrupted superblock when we can't validate it and
> continue with repair?
> I wonder if something like
> # xfs_repair --allow-single-sb
> should be required, with some man page docs suggesting a run with -n
> first etc to be sure that garbled geometry doesn't trash the whole thing...?

Maybe.  Given that we don't auto fsck anyway it's at least doable.  But
given that there is no other way to repair a single AG filesystem I'm
not sure it helps.  But I can cook up a variant that requires an option.
In fact existing repair code would allow it (and fail utterly) when
a flag is set - there's just no way to set that flag on the command

<Prev in Thread] Current Thread [Next in Thread>