xfs
[Top] [All Lists]

Re: [PATCH] create xfstests install target

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] create xfstests install target
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Fri, 02 Jan 2009 12:26:21 -0600
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20090102180247.GC29506@xxxxxxxxxxxxx>
References: <495D42CE.6060806@xxxxxxxxxxx> <20090102180247.GC29506@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.19 (Macintosh/20081209)
Christoph Hellwig wrote:
> On Thu, Jan 01, 2009 at 04:25:18PM -0600, Eric Sandeen wrote:
>> Not sure what the best location for this is in the end, but that's
>> just a one-line change in builddefs.in if it should move.  Currently
>> it goes to whatever configure thinks "libexecdir" is.
> 
> I think that's incorrect. libexecdir is /usr/lib for FHS or /usr/libexec
> for BSDish filesystem layouts, but /use should be read-only mountable.
> 
> Maybe /var/lib/xfstests as a start?  That seems to be the dumping ground
> for random stuff that needs write access.  

Ok, easy enough.

> Even better would be keeping
> the scripts under /usr/lib and the output in /var/lib, but that might
> be too much work.

Yeah at least right now I'm not that highly motivated.  :)

>> +PKG_SBIN_DIR    = @sbindir@
> 
> This one doesn't actually seem to be used.

true, it's not ... I put it in there thinking about putting a wrapper in
sbin or /usr/sbin so tests could be launched from root's path ...

-Eric

> Otherwise looks good to me.
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>