xfs
[Top] [All Lists]

Re: [PATCH] remove flags param from xfs_free_eofblocks

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] remove flags param from xfs_free_eofblocks
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 01 Jan 2009 17:04:39 -0600
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20090101230354.GF7510@xxxxxxxxxxxxx>
References: <495D478B.9080702@xxxxxxxxxxx> <20090101225717.GE7510@xxxxxxxxxxxxx> <20090101230354.GF7510@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.19 (Macintosh/20081209)
Christoph Hellwig wrote:
> On Thu, Jan 01, 2009 at 05:57:17PM -0500, Christoph Hellwig wrote:
>> On Thu, Jan 01, 2009 at 04:45:31PM -0600, Eric Sandeen wrote:
>>> Remove unused XFS_FREE_EOF_NOLOCK and make XFS_FREE_EOF_LOCK default.
>>>
>>> XFS_FREE_EOF_NOLOCK is never used, so remove it, make
>>> XFS_FREE_EOF_LOCK the only behavior, and remove the
>>> flags parameters.
>> Looks good to me.  
> 
> Actually it's used by dmapi, so we have to keep it.  Would be nice if
> we actually had some uptodate tree with dmapi, though..
> 

yep I had the wrong tree :(  sorry for the noise.

-Eric

<Prev in Thread] Current Thread [Next in Thread>