| To: | "Dave Chinner" <david@xxxxxxxxxxxxx>, "Christoph Hellwig" <hch@xxxxxxxxxxxxx>, xfs-masters@xxxxxxxxxxx, xfs@xxxxxxxxxxx, kernel-testers@xxxxxxxxxxxxxxx |
|---|---|
| Subject: | Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108 |
| From: | "Alexander Beregalov" <a.beregalov@xxxxxxxxx> |
| Date: | Mon, 12 Jan 2009 11:08:55 +0300 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=FwbXX/3AtsW4uWQnYQX6bTx64OFbJtYffmeI1RShqco=; b=jHP5JplZcIiqts0LOmBtTGnH+w2EWwyga8IqA1FAn+qAAFnxuNtL3ON8h4QPl4rlMc U6yPUxZKgeSCqLiSkAppdB0ZPj3rYYaappFXcWrGDeE5i3+THTlH5HfalosWmtaL9sD3 EOBWqSwWR56J36mTaMExBfBxlzo3oLEs9Te9s= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=RGtfBoyzj/TslgcvsB2IxQhSpZgOU5HSncxn46YM5uaTl5o0rNF7/rIZZ+M+SAFNjm vEsdCfePqFHhgI33EsijgjWLEwDrlEwbw0XnQCtEOryXRYbTpTpYMERxf6LeyEoryEj6 mP17hwf8WdLaPwyjxeHGIlWbtI+m0Zuud0Nl8= |
| In-reply-to: | <20090112034550.GI8071@disturbed> |
| References: | <a4423d670901091353s7ff12207gcb38eb093d77d401@mail.gmail.com> <a4423d670901091511y68a53808rfaab8148526224c6@mail.gmail.com> <a4423d670901100419s2ae106bexac1a538caf654153@mail.gmail.com> <20090110143924.GA25900@infradead.org> <a4423d670901100709v1e7ce0bfs167547c5001787ac@mail.gmail.com> <20090110152803.GA7469@infradead.org> <20090110221459.GA8873@orion> <20090111104659.GB8071@disturbed> <a4423d670901111648w26e86baajcf7b6d98ff37d043@mail.gmail.com> <20090112034550.GI8071@disturbed> |
2009/1/12 Dave Chinner <david@xxxxxxxxxxxxx>: > On Mon, Jan 12, 2009 at 03:48:13AM +0300, Alexander Beregalov wrote: >> > Hmmmm - this might be getting closer to the source of the bug. >> > It's being detecting when reading in the buffer to do a left shift >> > now, not during the delete of a record. >> > >> > I'd suggest that you treat this as the same failure and continue >> > the bisect to try to find when no problems show up at all. >> >> 687b890a184fef263ebb773926e1f4aa69240d01 is the first bad commit. > > [XFS] implement generic xfs_btree_lshift > > Make the btree left shift code generic. Based on a patch from David > Chinner with lots of changes to follow the original btree implementations > more closely. While this loses some of the generic helper routines for > inserting/moving/removing records it also solves some of the one off bugs > in the original code and makes it easier to verify. > >> Does it make sense? > > Yes, a bug in that patch could corrupt the btree in memory which we then trip > over later in delrec before it has been written to disk. > > Thank you for isolating the problem to that commit - it greatly narrows down > the amount of code we need to search to find the bug. I'll have a look tonight > to see if I can spot the problem. It seems 9eaead5 (implement generic xfs_btree_rshift) is really guilty, unless the bug "XFS internal error xfs_btree_check_lblock at line 200 of file fs/xfs/xfs_btree.c:" which I posted 5 hours ago is completely different from the original bug message. I can not reproduce the bug on 278d0ca14. |
| Previous by Date: | Email Account, Technical Support Team |
|---|---|
| Next by Date: | spurious -ENOSPC on XFS, Mikulas Patocka |
| Previous by Thread: | Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108, Dave Chinner |
| Next by Thread: | Re: [xfs-masters] 2.6.29-rc: kernel BUG at fs/xfs/support/debug.c:108, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |