xfs
[Top] [All Lists]

Re: [PATCH 3/3] xfs: make xfs_ino_t an unsigned long long

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/3] xfs: make xfs_ino_t an unsigned long long
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 9 Jan 2009 09:44:13 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20090108184430.967925000@bombadil.infradead.org>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <20090108184222.244013000@bombadil.infradead.org> <20090108184430.967925000@bombadil.infradead.org>
User-agent: Mutt/1.5.18 (2008-05-17)
On Thu, Jan 08, 2009 at 01:42:25PM -0500, Christoph Hellwig wrote:
> Currently xfs_ino_t is defined as a u64 which can either be an unsigned
> long long or on some 64 bit platforms and unsigned long.  Just making
> it and unsigned long long mean's it's still always 64 bits wide, but we
> don't need to resort to cases to print it.
> 
> Fixes a warning regression on 64 bit powerpc in current git.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Index: xfs/fs/xfs/xfs_types.h
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_types.h       2009-01-01 11:53:17.321546620 +0100
> +++ xfs/fs/xfs/xfs_types.h    2009-01-05 20:30:04.794549213 +0100
> @@ -45,7 +45,7 @@ typedef __uint32_t          prid_t;         /* project 
>  typedef __uint32_t           inst_t;         /* an instruction */
>  
>  typedef __s64                        xfs_off_t;      /* <file offset> type */
> -typedef __u64                        xfs_ino_t;      /* <inode> type */
> +typedef unsigned long long   xfs_ino_t;      /* <inode> type */
>  typedef __s64                        xfs_daddr_t;    /* <disk address> type 
> */
>  typedef char *                       xfs_caddr_t;    /* <core address> type 
> */
>  typedef __u32                        xfs_dev_t;

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>