xfs
[Top] [All Lists]

Re: [PATCH 3/5] xfstests: test 195, add a testcase for the nodump flag

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/5] xfstests: test 195, add a testcase for the nodump flag
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 30 Dec 2008 20:55:41 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20081230230913.302710000@xxxxxxxxxxxxxxxxxxxxxx>
References: <20081230230810.986105000@xxxxxxxxxxxxxxxxxxxxxx> <20081230230913.302710000@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.18 (Macintosh/20081105)
Christoph Hellwig wrote:

> Based on http://oss.sgi.com/bugzilla/show_bug.cgi?id=340.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Index: xfstests/195

...

> +_do_dump()
> +{
> +     xfsdump -l 0 -s d -F  \
> +             -L prova -M prova \
> +             -f $TEST_DIR/dumpfile -e -v excluded_files=debug $TEST_DIR \
> +             | grep "ino $inum" \
> +             | sed -e 's/xfsdump: pruned ino [0-9]*, owner 0, estimated size 
> 0: skip flag set/xfsdump: pruned ino NNN, owner 0, estimated size 0: skip 
> flag set/'
> +}

That's a bigger pattern than I'd have matched but as far as bike sheds
go, looks good to me :)

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>