xfs
[Top] [All Lists]

Re: [PATCH 1/5] xfstests: fix compiler warnings

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/5] xfstests: fix compiler warnings
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 30 Dec 2008 19:59:11 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20081230230912.986540000@xxxxxxxxxxxxxxxxxxxxxx>
References: <20081230230810.986105000@xxxxxxxxxxxxxxxxxxxxxx> <20081230230912.986540000@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.18 (Macintosh/20081105)
Christoph Hellwig wrote:

(hmm we need to teach quilt not to do attachments...)

...

> Index: xfstests/src/looptest.c
> ===================================================================
> --- xfstests/src/looptest.c   2008-12-30 14:51:21.000000000 +0000
> +++ xfstests/src/looptest.c   2008-12-30 14:51:31.000000000 +0000
> @@ -28,8 +28,6 @@
>   
>  /* dxm - 28/2/2 */
>  
> -#define _GNU_SOURCE
> -
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <malloc.h>

...

Just in case this gets transplanted outside xfstests, where _GNU_SOURCE
may not be defined on the make commandline, would it make sense to just
put this #define inside

#ifndef _GNU_SOURCE?

Just a thought; otherwise looks good to me.

-Eric

<Prev in Thread] Current Thread [Next in Thread>