xfs
[Top] [All Lists]

Re: [PATCH] xfs-cmds: fix parallel installs in include/ dirs

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs-cmds: fix parallel installs in include/ dirs
From: Mike Frysinger <vapier@xxxxxxxxxx>
Date: Tue, 30 Dec 2008 15:19:41 -0500
Cc: Eric Sandeen <sandeen@xxxxxxxxxxx>, "xfs-oss" <xfs@xxxxxxxxxxx>
In-reply-to: <20081230171825.GA31624@xxxxxxxxxxxxx>
Organization: wh0rd.org
References: <49594CD9.3010402@xxxxxxxxxxx> <200812300907.31459.vapier@xxxxxxxxxx> <20081230171825.GA31624@xxxxxxxxxxxxx>
User-agent: KMail/1.10.3 (Linux/2.6.28; KDE/4.1.3; x86_64; ; )
On Tuesday 30 December 2008 12:18:25 Christoph Hellwig wrote:
> On Tue, Dec 30, 2008 at 09:07:30AM -0500, Mike Frysinger wrote:
> > acl-2.2.47 built fine for me with `./configure && make` and this patch
> > ...
>
> Works now after a make distclean for me.
>
> > that said, if the only purpose of this is to make sure there are symlinks
> > in include/, why not do it at the tail end of configure ?  then there
> > will be no weird parallel magic to worry about, and everything will
> > always be available once configure has finished.
>
> I'll leave that to Eric or anyone else who wants to play a build system
> expert on TV :)

it's easy to do, i just dont know how people feel about the idea in general
diff --git a/configure.in b/configure.in
index 3c46c49..d227630 100644
--- a/configure.in
+++ b/configure.in
@@ -27,4 +27,11 @@ AC_MANUAL_FORMAT
 
 AC_FUNC_GCC_VISIBILITY
 
-AC_OUTPUT(include/builddefs)
+AC_CONFIG_FILES(include/builddefs)
+AC_CONFIG_COMMANDS([include-symlinks], [
+       rm -f include/acl include/sys
+       ln -s . include/acl
+       ln -s . include/sys
+])
+AC_OUTPUT
+
diff --git a/include/Makefile b/include/Makefile
index f2eca14..d606fa2 100644
--- a/include/Makefile
+++ b/include/Makefile
@@ -10,13 +10,10 @@ LSRCFILES = builddefs.in buildmacros buildrules 
config.h.in
 LDIRT = sys acl
 
 default:
-       rm -f sys acl
-       $(LN_S) . sys
-       $(LN_S) . acl
 
 include $(BUILDRULES)
 
-install-dev: default
+install-dev:
        $(INSTALL) -m 755 -d $(PKG_INC_DIR)
        $(INSTALL) -m 755 -d $(PKG_INC_DIR)/sys
        $(INSTALL) -m 644 acl.h $(PKG_INC_DIR)/sys/acl.h
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

<Prev in Thread] Current Thread [Next in Thread>