xfs
[Top] [All Lists]

Re: [PATCH] xfs-cmds: fix parallel installs in include/ dirs

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH] xfs-cmds: fix parallel installs in include/ dirs
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 30 Dec 2008 07:49:36 -0500
Cc: Mike Frysinger <vapier@xxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20081230115224.GA24210@xxxxxxxxxxxxx>
References: <49594CD9.3010402@xxxxxxxxxxx> <20081230115224.GA24210@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Dec 30, 2008 at 06:52:24AM -0500, Christoph Hellwig wrote:
> On Mon, Dec 29, 2008 at 04:19:05PM -0600, Eric Sandeen wrote:
> > This is for http://oss.sgi.com/bugzilla/show_bug.cgi?id=759
> > "fix parallel issue with include/ symlinks"
> > 
> > Doing something like "make -j2 install install-dev" would lead
> > to a race of removing & creating symlinks in include/
> > 
> > Thanks to Mike for reporting & suggesting the fix.
> 
> Looks good and I've put in in my queue.

Actually spoken too soon.   This breaks the acl build for me with:

 gcc -g -O2 -DNDEBUG -funsigned-char -fno-strict-aliasing -Wall
 -DVERSION=\"2.2.47\" -DLOCALEDIR=\"/usr/share/locale\"
 -DPACKAGE=\"acl\" -I../include -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64
 -include perm_copy.h -c acl_get_fd.c  -fPIC -DPIC -o .libs/acl_get_fd.o
 acl_get_fd.c:27:24: error: acl/libacl.h: No such file or directory
 acl_get_fd.c: In function 'acl_get_fd':
 acl_get_fd.c:62: warning: implicit declaration of function
 'acl_from_mode'
 acl_get_fd.c:62: warning: return makes pointer from integer without a
 cast

It looks like the acl link in include/ doesn't get created properly
with this patch.

<Prev in Thread] Current Thread [Next in Thread>