xfs
[Top] [All Lists]

Re: [PATCH, RFC] xfs_repair: allow filesystems with a single AG

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH, RFC] xfs_repair: allow filesystems with a single AG
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 25 Dec 2008 11:54:00 -0600
Cc: Arkadiusz Miskiewicz <arekm@xxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20081224231901.GA652@xxxxxxxxxxxxx>
References: <20081224231901.GA652@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.18 (Macintosh/20081105)
Christoph Hellwig wrote:
> Currently xfs_repair bails out on a filesystem with just a single AG.
> But that's a perfectly valid configureation, so we should allow it.
> 
> Skip the geomery validation because we simply can't do it if we don't
> have a secondary SB, and make sure to take the internal log into account
> when guestimating the first inode cluster.
> 
> I'll also cook up a testcase for repair on single AG filesystems.

While I think we should certainly allow this, what's the worst-case
scenario for a corrupted superblock when we can't validate it and
continue with repair?

I wonder if something like

# xfs_repair --allow-single-sb

should be required, with some man page docs suggesting a run with -n
first etc to be sure that garbled geometry doesn't trash the whole thing...?

-Eric

<Prev in Thread] Current Thread [Next in Thread>