xfs
[Top] [All Lists]

[XFS updates] XFS development tree branch, master, updated. v2.6.28-rc3-

To: xfs@xxxxxxxxxxx
Subject: [XFS updates] XFS development tree branch, master, updated. v2.6.28-rc3-1829-g2505115
From: xfs@xxxxxxxxxxx
Date: Tue, 23 Dec 2008 21:06:37 -0600
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "XFS development tree".

The branch, master has been updated
  2505115 [XFS] Fix race in xfs_write() between direct and buffered I/O with 
DMAPI
      from  ad1ad968f4e7b06c75741575ea077e25a87da49a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 25051158bbed127e8672b43396c71c5eb610e5f1
Author: Lachlan McIlroy <lachlan@xxxxxxxxxxxxxxxxxxxxxxxxx>
Date:   Wed Dec 24 14:07:32 2008 +1100

    [XFS] Fix race in xfs_write() between direct and buffered I/O with DMAPI
    
    The iolock is dropped and re-acquired around the call to XFS_SEND_NAMESP().
    While the iolock is released the file can become cached.  We then
    'goto retry' and - if we are doing direct I/O - mapping->nrpages may now be
    non zero but need_i_mutex will be zero and we will hit the WARN_ON().
    
    Since we have dropped the I/O lock then the file size may have also changed
    so what we need to do here is 'goto start' like we do for the 
XFS_SEND_DATA()
    DMAPI event.
    
    We also need to update the filesize before releasing the iolock so that
    needs to be done before the XFS_SEND_NAMESP event.  If we drop the iolock
    before setting the filesize we could race with a truncate.
    
    Reviewed-by: Christoph Hellwig <hch@xxxxxxxxxxxxx>
    Signed-off-by: Lachlan McIlroy <lachlan@xxxxxxx>

-----------------------------------------------------------------------

Summary of changes:
 fs/xfs/linux-2.6/xfs_lrw.c |   27 ++++++++++++---------------
 1 files changed, 12 insertions(+), 15 deletions(-)


hooks/post-receive
-- 
XFS development tree

<Prev in Thread] Current Thread [Next in Thread>
  • [XFS updates] XFS development tree branch, master, updated. v2.6.28-rc3-1829-g2505115, xfs <=