xfs
[Top] [All Lists]

Re: [Fwd: [PATCH] Fix race in xfs_write() between direct and buffered I/

To: Lachlan McIlroy <lachlan@xxxxxxx>
Subject: Re: [Fwd: [PATCH] Fix race in xfs_write() between direct and buffered I/O with DMAPI]
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 23 Dec 2008 03:40:13 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <49503378.2080508@xxxxxxx>
References: <493779B1.3010703@xxxxxxx> <20081208225125.GA15647@xxxxxxxxxxxxx> <493DFDBD.7060909@xxxxxxx> <20081209092240.GA23915@xxxxxxxxxxxxx> <20081222085311.GB24795@xxxxxxxxxxxxx> <49503378.2080508@xxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Dec 23, 2008 at 11:40:24AM +1100, Lachlan McIlroy wrote:
> Christoph Hellwig wrote:
> > Do you need more input on this one?
> 
> Actually I just might.  Based on your last reponse I wasn't sure if
> you wanted me to make further changes.

Well, my reponse was that I think we could do it more effecient, but the
patch still looks correct to me.

> Then I got side-tracked wondering
> why we even have the 'goto retry' in the dmapi post event - why retry the
> write if we get ENOSPC when we don't if dmapi is not enabled?  Could the
> write get stuck in an infinite loop?

We only retry on ENOSPC if the dmapi nospace even is enabled, or am I
missing something?

<Prev in Thread] Current Thread [Next in Thread>