[Top] [All Lists]

Re: [PATCH] handle unaligned data in xfs_bmbt_disk_get_all

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] handle unaligned data in xfs_bmbt_disk_get_all
From: Lachlan McIlroy <lachlan@xxxxxxx>
Date: Tue, 23 Dec 2008 11:45:09 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20081222145906.GA18859@xxxxxxxxxxxxx>
Organization: SGI
References: <20081222145906.GA18859@xxxxxxxxxxxxx>
Reply-to: lachlan@xxxxxxx
User-agent: Thunderbird (X11/20081105)
Looks good.

Christoph Hellwig wrote:
In libxfs xfs_bmbt_disk_get_all needs to handle unaligned data and thus
has been updated to use get_unaligned_be64.  In kernelspace we don't strictly
need it as the routine is only used for tracing and xfsidbg, but let's keep
the two implementations in sync.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Index: xfs/fs/xfs/xfs_bmap_btree.c
--- xfs.orig/fs/xfs/xfs_bmap_btree.c    2008-12-19 15:02:53.998907997 +0100
+++ xfs/fs/xfs/xfs_bmap_btree.c 2008-12-22 14:43:41.507247175 +0100
@@ -208,7 +208,8 @@ xfs_bmbt_disk_get_all(
        xfs_bmbt_rec_t  *r,
        xfs_bmbt_irec_t *s)
-       __xfs_bmbt_get_all(be64_to_cpu(r->l0), be64_to_cpu(r->l1), s);
+       __xfs_bmbt_get_all(get_unaligned_be64(&r->l0),
+                               get_unaligned_be64(&r->l1), s);

xfs mailing list

<Prev in Thread] Current Thread [Next in Thread>