xfs
[Top] [All Lists]

Re: [Fwd: [PATCH] Fix race in xfs_write() between direct and buffered I/

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [Fwd: [PATCH] Fix race in xfs_write() between direct and buffered I/O with DMAPI]
From: Lachlan McIlroy <lachlan@xxxxxxx>
Date: Tue, 23 Dec 2008 11:40:24 +1100
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20081222085311.GB24795@xxxxxxxxxxxxx>
Organization: SGI
References: <493779B1.3010703@xxxxxxx> <20081208225125.GA15647@xxxxxxxxxxxxx> <493DFDBD.7060909@xxxxxxx> <20081209092240.GA23915@xxxxxxxxxxxxx> <20081222085311.GB24795@xxxxxxxxxxxxx>
Reply-to: lachlan@xxxxxxx
User-agent: Thunderbird 2.0.0.18 (X11/20081105)
Christoph Hellwig wrote:
Do you need more input on this one?

Actually I just might.  Based on your last reponse I wasn't sure if
you wanted me to make further changes.  Then I got side-tracked wondering
why we even have the 'goto retry' in the dmapi post event - why retry the
write if we get ENOSPC when we don't if dmapi is not enabled?  Could the
write get stuck in an infinite loop?

<Prev in Thread] Current Thread [Next in Thread>