xfs
[Top] [All Lists]

Re: [PATCH][RFC] fs: Add new pre-allocation ioctls to vfs for compatibil

To: Felix Blyakher <felixb@xxxxxxx>
Subject: Re: [PATCH][RFC] fs: Add new pre-allocation ioctls to vfs for compatibility with legacy xfs ioctls
From: Ankit Jain <me@xxxxxxxxxxxxx>
Date: Thu, 18 Dec 2008 15:24:43 +0530
Cc: Al Viro <viro@xxxxxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, mfasheh@xxxxxxxx, joel.becker@xxxxxxxxxx, ocfs2-devel@xxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xfs-masters@xxxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <9D2593C9-08EB-486C-AAF5-E83A1EAEE9B9@xxxxxxx>
References: <49460F88.2080408@xxxxxxxxxxxxx> <9D2593C9-08EB-486C-AAF5-E83A1EAEE9B9@xxxxxxx>
User-agent: Thunderbird 2.0.0.18 (X11/20081112)
Felix Blyakher wrote:
> 
>> This patch adds ioctls to vfs for compatibility with legacy XFS
>> pre-allocation ioctls (XFS_IOC_*RESVP*). The implementation
>> effectively invokes sys_fallocate for the new ioctls.
> 
> I don't think we can use sys_fallocate for XFS_IOC_UNRESVSP*
> commands, which suppose to release currently allocated file
> blocks.
> See more comments below.

My bad :( I'll drop the *UNRESV* completely from the new ioctl and
post an updated patch.

-Ankit

<Prev in Thread] Current Thread [Next in Thread>