| To: | Eric Sandeen <sandeen@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] avoid memory allocations in xfs_fs_vcmn_err |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Wed, 17 Dec 2008 12:57:50 -0500 |
| Cc: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx, Alexander Beregalov <a.beregalov@xxxxxxxxx> |
| In-reply-to: | <49493AE5.2050202@xxxxxxxxxxx> |
| References: | <20081217172736.GA10797@xxxxxxxxxxxxx> <49493AE5.2050202@xxxxxxxxxxx> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Wed, Dec 17, 2008 at 11:46:13AM -0600, Eric Sandeen wrote: > Do we really want to drop the whole message if the fs name can't fit? > Maybe drop the fsname altogether and print the error anyway? Being > completely silent doesn't sound great... That's what we effecitvely do now, except that we still call snprintf. I think it's an unlikely enough case that we don't need to worry about it. And if long enough device names become common we can just increase the buffer size. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] avoid memory allocations in xfs_fs_vcmn_err, Eric Sandeen |
|---|---|
| Next by Date: | Re: [PATCH] avoid memory allocations in xfs_fs_vcmn_err, Eric Sandeen |
| Previous by Thread: | Re: [PATCH] avoid memory allocations in xfs_fs_vcmn_err, Eric Sandeen |
| Next by Thread: | Re: [PATCH] avoid memory allocations in xfs_fs_vcmn_err, Eric Sandeen |
| Indexes: | [Date] [Thread] [Top] [All Lists] |