xfs
[Top] [All Lists]

Re: [PATCH] avoid memory allocations in xfs_fs_vcmn_err

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] avoid memory allocations in xfs_fs_vcmn_err
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 17 Dec 2008 11:46:13 -0600
Cc: xfs@xxxxxxxxxxx, Alexander Beregalov <a.beregalov@xxxxxxxxx>
In-reply-to: <20081217172736.GA10797@xxxxxxxxxxxxx>
References: <20081217172736.GA10797@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.18 (Macintosh/20081105)
Christoph Hellwig wrote:

> +     if (mp) {
> +             len = sprintf(message, "Filesystem \"%s\": ", mp->m_fsname);
> +
> +             /*
> +              * Skip the printk if we can't print anything useful
> +              * due to an over-long device name.
> +              */
> +             if (len >= sizeof(message))
> +                     goto out;


Do we really want to drop the whole message if the fs name can't fit?
Maybe drop the fsname altogether and print the error anyway?  Being
completely silent doesn't sound great...

-Eric

<Prev in Thread] Current Thread [Next in Thread>