[Top] [All Lists]

Re: [PATCH] Remove XFS_BUF_SHUT() and friends

To: Lachlan McIlroy <lachlan@xxxxxxx>
Subject: Re: [PATCH] Remove XFS_BUF_SHUT() and friends
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 17 Dec 2008 09:20:40 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4938A58F.6090109@xxxxxxx>
References: <49378654.2050707@xxxxxxx> <20081204132746.GA27400@xxxxxxxxxxxxx> <4938A58F.6090109@xxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Fri, Dec 05, 2008 at 02:52:47PM +1100, Lachlan McIlroy wrote:
> Christoph Hellwig wrote:
> > On Thu, Dec 04, 2008 at 06:27:16PM +1100, Lachlan McIlroy wrote:
> >> Code does nothing so remove it.
> > 
> > Looks good to me.  Does anyone remember why this flag was set on IRIX?
> During a forced shutdown we would go through all incore buffers and mark
> them B_STALE/B_ERROR/B_SHUT and then call biodone() on them.  The code in
> xfs_buf_iodone_callbacks() that checks for B_SHUT is to avoid a double
> biodone() I think.  We don't have the code in the Linux port that scans
> through all the incore buffers on a forced shutdown but we still have one
> case in xfs_iflush_cluster().  In any case it's not doing anything.


<Prev in Thread] Current Thread [Next in Thread>