xfs
[Top] [All Lists]

Re: [PATCH] xfs_quota: Warn if specified non-zero quota will be round do

To: Arkadiusz Miskiewicz <arekm@xxxxxxxx>
Subject: Re: [PATCH] xfs_quota: Warn if specified non-zero quota will be round down to zero.
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Mon, 15 Dec 2008 19:27:24 -0600
Cc: linux-xfs@xxxxxxxxxxx
In-reply-to: <1229383657-45951-1-git-send-email-arekm@xxxxxxxx>
References: <1229383657-45951-1-git-send-email-arekm@xxxxxxxx>
User-agent: Thunderbird 2.0.0.18 (Macintosh/20081105)
Arkadiusz Miskiewicz wrote:
> User specified quota limit is internally converted to "basic blocks"
> unit (512 bytes in size). Quota value will be silently converted
> to zero when user enters any value lower than 512 bytes.
> 
> Warn in such case:
> 
> : # ./xfs_quota -x -c "limit -u bsoft=431 12000" /home
> : xfs_quota: Warning: `431' in quota blocks is 0 (unlimited).


Looks good to me.

-Eric

> ---
>  xfsprogs/po/pl.po     |    5 +++++
>  xfsprogs/quota/edit.c |    2 ++
>  2 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/xfsprogs/po/pl.po b/xfsprogs/po/pl.po
> index b4e1d76..d13184b 100644
> --- a/xfsprogs/po/pl.po
> +++ b/xfsprogs/po/pl.po
> @@ -3670,6 +3670,11 @@ msgstr "%s: nieprawid
>  msgid "%s: invalid project name: %s\n"
>  msgstr "%s: nieprawid³owa nazwa projektu: %s\n"
>  
> +#: ../quota/edit.c:237
> +#, c-format
> +msgid "%s: Warning: `%s' in quota blocks is 0 (unlimited).\n"
> +msgstr "%s: Uwaga: `%s' w blokach quoty oznacza 0 (nieograniczone).\n"
> +
>  #: ../quota/edit.c:318
>  #, c-format
>  msgid "%s: unrecognised argument %s\n"
> diff --git a/xfsprogs/quota/edit.c b/xfsprogs/quota/edit.c
> index 15c72c4..ce7f7e9 100644
> --- a/xfsprogs/quota/edit.c
> +++ b/xfsprogs/quota/edit.c
> @@ -233,6 +233,8 @@ extractb(
>               s = string + length + 1;
>               v = (__uint64_t)cvtnum(blocksize, sectorsize, s);
>               *value = v >> 9;        /* syscalls use basic blocks */
> +             if (v > 0 && *value == 0)
> +                     fprintf(stderr, _("%s: Warning: `%s' in quota blocks is 
> 0 (unlimited).\n"), progname, s);
>               return 1;
>       }
>       return 0;
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs

<Prev in Thread] Current Thread [Next in Thread>