xfs
[Top] [All Lists]

Re: [patch 5/5] use inode_change_ok for setattr permission checking

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [patch 5/5] use inode_change_ok for setattr permission checking
From: Timothy Shimmin <tes@xxxxxxx>
Date: Wed, 10 Dec 2008 16:09:06 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20081209094801.643772000@xxxxxxxxxxxxxxxxxxxxxx>
References: <20081209094729.939583000@xxxxxxxxxxxxxxxxxxxxxx> <20081209094801.643772000@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.17 (Macintosh/20080914)
Christoph Hellwig wrote:
> Instead of implementing our own checks use inode_change_ok to check for
> necessary permission in setattr.  There is a slight change in behaviour
> as inode_change_ok doesn't allow i_mode updates to add the suid or sgid
> without superuser privilegues while the old XFS code just stripped away
> those bits from the file mode.
> 
> (First sent on Semptember 29th)
(No reply from Question on Nov 12th:)

I just wanted to run this thru an amended xfstests/193 first.

Thanks,
--Tim

<Prev in Thread] Current Thread [Next in Thread>