xfs
[Top] [All Lists]

Re: [PATCH, RFC] - set b_error from bio error in xfs_buf_bio_end_io

To: lachlan@xxxxxxx
Subject: Re: [PATCH, RFC] - set b_error from bio error in xfs_buf_bio_end_io
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 04 Dec 2008 22:09:57 -0600
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4938A8C1.7030103@xxxxxxx>
References: <4938A4C1.9010401@xxxxxxxxxxx> <4938A8C1.7030103@xxxxxxx>
User-agent: Thunderbird 2.0.0.18 (Macintosh/20081105)
Lachlan McIlroy wrote:

> I would suggest this:
> 
> @@ -1114,8 +1140,7 @@ xfs_buf_bio_end_io(
>       unsigned int            blocksize = bp->b_target->bt_bsize;
>       struct bio_vec          *bvec = bio->bi_io_vec + bio->bi_vcnt - 1;
> 
> -     if (!test_bit(BIO_UPTODATE, &bio->bi_flags))
> -             bp->b_error = EIO;
> +     xfs_buf_ioerror(bp, -error);

oh, sure.  I forgot we had the wrapper to set the error ... :)

> The BIO_UPTODATE checks have already been done before calling this function
> and error has been set appropriately so we can just use it.

ah so it is.   yeah, makes perfect sense.

-Eric

<Prev in Thread] Current Thread [Next in Thread>