Re: [PATCH, RFC] - set b_error from bio error in xfs_buf_bio_end_io

[Eric Sandeen <sandeen@xxxxxxxxxxx>]

Lachlan McIlroy wrote:

> I would suggest this:
> 
> @@ -1114,8 +1140,7 @@ xfs_buf_bio_end_io(
>       unsigned int            blocksize = bp->b_target->bt_bsize;
>       struct bio_vec          *bvec = bio->bi_io_vec + bio->bi_vcnt - 1;
> 
> -     if (!test_bit(BIO_UPTODATE, &bio->bi_flags))
> -             bp->b_error = EIO;
> +     xfs_buf_ioerror(bp, -error);

oh, sure.  I forgot we had the wrapper to set the error ... :)

> The BIO_UPTODATE checks have already been done before calling this function
> and error has been set appropriately so we can just use it.

ah so it is.   yeah, makes perfect sense.

-Eric