xfs
[Top] [All Lists]

Re: [PATCH] Remove XFS_BUF_SHUT() and friends

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] Remove XFS_BUF_SHUT() and friends
From: Lachlan McIlroy <lachlan@xxxxxxx>
Date: Fri, 05 Dec 2008 14:52:47 +1100
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <20081204132746.GA27400@xxxxxxxxxxxxx>
References: <49378654.2050707@xxxxxxx> <20081204132746.GA27400@xxxxxxxxxxxxx>
Reply-to: lachlan@xxxxxxx
User-agent: Thunderbird 2.0.0.18 (X11/20081105)
Christoph Hellwig wrote:
On Thu, Dec 04, 2008 at 06:27:16PM +1100, Lachlan McIlroy wrote:
Code does nothing so remove it.

Looks good to me.  Does anyone remember why this flag was set on IRIX?

During a forced shutdown we would go through all incore buffers and mark
them B_STALE/B_ERROR/B_SHUT and then call biodone() on them.  The code in
xfs_buf_iodone_callbacks() that checks for B_SHUT is to avoid a double
biodone() I think.  We don't have the code in the Linux port that scans
through all the incore buffers on a forced shutdown but we still have one
case in xfs_iflush_cluster().  In any case it's not doing anything.

<Prev in Thread] Current Thread [Next in Thread>