xfs
[Top] [All Lists]

Re: [PATCH] Check return value of xfs_buf_get_noaddr()

To: lachlan@xxxxxxx
Subject: Re: [PATCH] Check return value of xfs_buf_get_noaddr()
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 04 Dec 2008 09:28:14 -0600
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <49376D11.4010507@xxxxxxx>
References: <49376D11.4010507@xxxxxxx>
User-agent: Thunderbird 2.0.0.18 (X11/20081119)
Lachlan McIlroy wrote:
> We check the return value of all other calls to xfs_buf_get_noaddr().
> Make sense to do it here too.
> 
> --- a/fs/xfs/xfs_vnodeops.c
> +++ b/fs/xfs/xfs_vnodeops.c
> @@ -3034,6 +3034,8 @@ xfs_zero_remaining_bytes(
>       bp = xfs_buf_get_noaddr(mp->m_sb.sb_blocksize,
>                               XFS_IS_REALTIME_INODE(ip) ?
>                               mp->m_rtdev_targp : mp->m_ddev_targp);
> +     if (!bp)
> +             return ENOMEM;

Maybe

+               return XFS_ERROR(ENOMEM);

-Eric

>       for (offset = startoff; offset <= endoff; offset = lastoffset + 1) {
>               offset_fsb = XFS_B_TO_FSBT(mp, offset);
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>