xfs
[Top] [All Lists]

Re: [PATCH] Remove unused variable in ktrace_free()

To: lachlan@xxxxxxx
Subject: Re: [PATCH] Remove unused variable in ktrace_free()
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Thu, 04 Dec 2008 09:29:35 -0600
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4937765D.2030601@xxxxxxx>
References: <4937765D.2030601@xxxxxxx>
User-agent: Thunderbird 2.0.0.18 (X11/20081119)
Lachlan McIlroy wrote:
> entries_size is probably left over from when we used to pass the
> size to kmem_free().

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

> --- xfs-fix.orig/fs/xfs/support/ktrace.c
> +++ xfs-fix/fs/xfs/support/ktrace.c
> @@ -113,21 +113,16 @@ ktrace_alloc(int nentries, unsigned int
>   void
>   ktrace_free(ktrace_t *ktp)
>   {
> -     int     entries_size;
> -
>       if (ktp == (ktrace_t *)NULL)
>               return;
> 
>       /*
>        * Special treatment for the Vnode trace buffer.
>        */
> -     if (ktp->kt_nentries == ktrace_zentries) {
> +     if (ktp->kt_nentries == ktrace_zentries)
>               kmem_zone_free(ktrace_ent_zone, ktp->kt_entries);
> -     } else {
> -             entries_size = (int)(ktp->kt_nentries * sizeof(ktrace_entry_t));
> -
> +     else
>               kmem_free(ktp->kt_entries);
> -     }
> 
>       kmem_zone_free(ktrace_hdr_zone, ktp);
>   }
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>