[Top] [All Lists]

Re: [patch 11/22] cleanup xfs_sb.h feature flag helpers

To: Donald Douwsma <donaldd@xxxxxxx>
Subject: Re: [patch 11/22] cleanup xfs_sb.h feature flag helpers
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 3 Dec 2008 05:52:44 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <49362688.4030200@xxxxxxx>
References: <20081202160430.775774000@xxxxxxxxxxxxxxxxxxxxxx> <20081202160651.115809000@xxxxxxxxxxxxxxxxxxxxxx> <49362688.4030200@xxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Dec 03, 2008 at 05:26:16PM +1100, Donald Douwsma wrote:
> Christoph Hellwig wrote:
> Looks ok, I think all these used to be macros, but when they got cleaned up
> a lot of grogens were left in place. I wish we could get all this kind of 
> thing
> cleaned up right first time...

I think this was Nathan's big sweap to kill xfs_macros.[ch] for the ugly
marcros turning into macros calling functions calling the original macro
crap.  He did this in some sort of scripted way and a lot of things like
this were left in place.

<Prev in Thread] Current Thread [Next in Thread>