[Top] [All Lists]

Re: [patch 07/22] stop using igrab in xfs_vn_link

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [patch 07/22] stop using igrab in xfs_vn_link
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 3 Dec 2008 13:39:48 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20081202160650.515494000@xxxxxxxxxxxxxxxxxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <20081202160430.775774000@xxxxxxxxxxxxxxxxxxxxxx> <20081202160650.515494000@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Dec 02, 2008 at 11:04:37AM -0500, Christoph Hellwig wrote:
> ->link is guranteed to get an already reference inode passed so we
> can do a simple increment of i_count instead of using igrab and thus
> avoid banging on the global inode_lock.  This is what most filesystems
> already do.
> Also move the increment after the call to xfs_link to simplify error
> handling.
> (First sent on July 26th)
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>