Re: [patch 07/22] stop using igrab in xfs_vn

xfs

Re: [patch 07/22] stop using igrab in xfs_vn_link

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [patch 07/22] stop using igrab in xfs_vn_link
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Wed, 3 Dec 2008 13:39:48 +1100
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20081202160650.515494000@xxxxxxxxxxxxxxxxxxxxxx>
Mail-followup-to:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References:	<20081202160430.775774000@xxxxxxxxxxxxxxxxxxxxxx> <20081202160650.515494000@xxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.18 (2008-05-17)

On Tue, Dec 02, 2008 at 11:04:37AM -0500, Christoph Hellwig wrote:
> ->link is guranteed to get an already reference inode passed so we
> can do a simple increment of i_count instead of using igrab and thus
> avoid banging on the global inode_lock.  This is what most filesystems
> already do.
> 
> Also move the increment after the call to xfs_link to simplify error
> handling.
> 
> (First sent on July 26th)
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [patch 08/22] reduce l_icloglock roundtrips, (continued) Re: [patch 08/22] reduce l_icloglock roundtrips, Christoph Hellwig [patch 12/22] kill dead inode flags, Christoph Hellwig Re: [patch 12/22] kill dead inode flags, Dave Chinner Re: [patch 12/22] kill dead inode flags, Niv Sardi Re: [patch 12/22] kill dead inode flags, Christoph Hellwig [patch 03/22] remove unused behvavior cruft in xfs_super.h, Christoph Hellwig Re: [patch 03/22] remove unused behvavior cruft in xfs_super.h, Dave Chinner [patch 06/22] kill xfs_buf_iostart, Christoph Hellwig Re: [patch 06/22] kill xfs_buf_iostart, Dave Chinner [patch 07/22] stop using igrab in xfs_vn_link, Christoph Hellwig Re: [patch 07/22] stop using igrab in xfs_vn_link, Dave Chinner <= [patch 13/22] remove unused m_inode_quiesce member from struct xfs_mount, Christoph Hellwig Re: [patch 13/22] remove unused m_inode_quiesce member from struct xfs_mount, Dave Chinner [patch 21/22] move inode tracing out of xfs_vnode., Christoph Hellwig Re: [patch 21/22] move inode tracing out of xfs_vnode., Dave Chinner Re: [patch 00/22] 2.6.29 queue, Christoph Hellwig

Previous by Date:	Re: [patch 06/22] kill xfs_buf_iostart, Dave Chinner
Next by Date:	Re: [patch 08/22] reduce l_icloglock roundtrips, Dave Chinner
Previous by Thread:	[patch 07/22] stop using igrab in xfs_vn_link, Christoph Hellwig
Next by Thread:	[patch 13/22] remove unused m_inode_quiesce member from struct xfs_mount, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]