[Top] [All Lists]

Re: [patch 06/22] kill xfs_buf_iostart

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [patch 06/22] kill xfs_buf_iostart
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 3 Dec 2008 13:37:54 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20081202160650.360918000@xxxxxxxxxxxxxxxxxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <20081202160430.775774000@xxxxxxxxxxxxxxxxxxxxxx> <20081202160650.360918000@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Dec 02, 2008 at 11:04:36AM -0500, Christoph Hellwig wrote:
> xfs_buf_iostart is a "shared" helper for xfs_buf_read_flags,
> xfs_bawrite, and xfs_bdwrite - except that there isn't much shared
> code but rather special cases for each caller.
> So remove this function and move the functionality to the caller.
> xfs_bawrite and xfs_bdwrite are now big enough to be moved out of
> line and the xfs_buf_read_flags is moved into a new helper called
> _xfs_buf_read.
> (First sent on August 2nd)
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>