xfs
[Top] [All Lists]

Re: [patch 02/22] remove useless mnt_want_write call in xfs_write

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [patch 02/22] remove useless mnt_want_write call in xfs_write
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Wed, 3 Dec 2008 13:11:02 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20081202160649.790190000@xxxxxxxxxxxxxxxxxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <20081202160430.775774000@xxxxxxxxxxxxxxxxxxxxxx> <20081202160649.790190000@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Dec 02, 2008 at 11:04:32AM -0500, Christoph Hellwig wrote:
> 
> When mnt_want_write was introduced a call to it was added around
> xfs_ichgtime, but there is no need for this because a file can't be open
> read/write on a r/o mount, and a mount can't degrade r/o while we still
> have files open for writing.  As the mnt_want_write changes were never
> merged into the CVS tree this patch is for mainline only.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>