xfs
[Top] [All Lists]

Re: [PATCH] xfsidbg: fix uninitialized variable warning

To: xfs@xxxxxxxxxxx
Subject: Re: [PATCH] xfsidbg: fix uninitialized variable warning
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 1 Dec 2008 07:04:26 -0500
In-reply-to: <20081112114609.GB15216@xxxxxxxxxxxxx>
References: <20081112114609.GB15216@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Nov 12, 2008 at 06:46:09AM -0500, Christoph Hellwig wrote:
> We don't initializ s.br_state in xfsidbg_btree_trace_record so gcc
> rightly complains about accessing it in xfsidbg_xbirec.  Given that we
> don't get the state value from the tracing code just opencode printing
> the other which actually reduces code size and makes the XFS_BTNUM_BMAP
> case in xfsidbg_btree_trace_record more similar to the others.

Ping?

> 
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Index: linux-2.6-xfs/fs/xfs/xfsidbg.c
> ===================================================================
> --- linux-2.6-xfs.orig/fs/xfs/xfsidbg.c       2008-11-12 11:14:39.000000000 
> +0100
> +++ linux-2.6-xfs/fs/xfs/xfsidbg.c    2008-11-12 11:17:14.000000000 +0100
> @@ -2759,16 +2759,11 @@ xfsidbg_btree_trace_record(
>  {
>       switch (btnum) {
>       case XFS_BTNUM_BMAP:
> -     {
> -             struct xfs_bmbt_irec s;
> -
> -             s.br_startoff = ((xfs_dfiloff_t)l0 << 32) | (xfs_dfiloff_t)l1;
> -             s.br_startblock = ((xfs_dfsbno_t)l2 << 32) | (xfs_dfsbno_t)l3;
> -             s.br_blockcount = ((xfs_dfilblks_t)l4 << 32) | 
> (xfs_dfilblks_t)l5;
> -
> -             xfsidbg_xbirec(&s);
> +             kdb_printf("startoff %Ld startblock %Lx blockcount %Ld\n",
> +                        ((xfs_dfiloff_t)l0 << 32) | (xfs_dfiloff_t)l1,
> +                        ((xfs_dfsbno_t)l2 << 32) | (xfs_dfsbno_t)l3,
> +                        ((xfs_dfilblks_t)l4 << 32) | (xfs_dfilblks_t)l5);
>               break;
> -     }
>       case XFS_BTNUM_BNO:
>       case XFS_BTNUM_CNT:
>               qprintf(" startblock = %d, blockcount = %d\n",
> 
> 
---end quoted text---

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] xfsidbg: fix uninitialized variable warning, Christoph Hellwig <=