xfs
[Top] [All Lists]

Re: [XFS updates] XFS public tree - master for latest XFS changes for ma

To: Niv Sardi <xaiki@xxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [XFS updates] XFS public tree - master for latest XFS changes for mainline, xfs-dev like master with kdb/dmapi branch, master, updated. v2.6.28-rc3-1049-g0924b58
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 1 Dec 2008 04:09:53 -0500
In-reply-to: <20081201064949.GL6291@disturbed>
References: <200812010015.mB10F1Ab031727@xxxxxxxxxxx> <20081201064949.GL6291@disturbed>
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Dec 01, 2008 at 05:49:49PM +1100, Dave Chinner wrote:
> On Sun, Nov 30, 2008 at 06:15:01PM -0600, Niv Sardi wrote:
> > - Log -----------------------------------------------------------------
> > commit 0924b585fc49bf371bc700c23e516a538bf589af
> > Author: Dave Chinner <david@xxxxxxxxxxxxx>
> > Date:   Fri Nov 28 14:23:34 2008 +1100
> > 
> >     [XFS] fix uninitialised variable bug in dquot release.
> >     
> >     gcc is warning about an uninitialised variable in xfs_growfs_rt().
> >     This is a false positive. Fix it by changing the scope of the
> >     transaction pointer to wholly within the internal loop inside
> >     the function.
> 
> The title of that doesn't match the description. I think it
> was supposed to be:
> 
> [PATCH 4/5] XFS: fix spurious uninitialised variable warning in xfs_growfs_rt

Looks like xaiki just sucked in my staging tree where I mistpasted the
subject line.

> BTW, can we get a one-line summary of the commits being referenced
> in the message? The commit hash is less than useful, and having to
> read through several hundred lines of commit logs to determine
> what was checked in is not fun.....

Yeah, the new sort of commit messags aren't too useful.  I would in fact
prefer to get the old style one mail per commit, maybe even including
the patch that was commited.  I'm sure this is doable with git as there
are a lot of projects that do it.


<Prev in Thread] Current Thread [Next in Thread>