| To: | Lachlan McIlroy <lachlan@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] Remove unnecessary assertion |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 4 Dec 2008 02:08:50 -0500 |
| Cc: | xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <49377863.1070109@sgi.com> |
| References: | <49377863.1070109@sgi.com> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Thu, Dec 04, 2008 at 05:27:47PM +1100, Lachlan McIlroy wrote: > Hit this assert because an inode was tagged with XFS_ICI_RECLAIM_TAG but > not XFS_IRECLAIMABLE|XFS_IRECLAIM. This is because xfs_iget_cache_hit() > first clears XFS_IRECLAIMABLE and then calls __xfs_inode_clear_reclaim_tag() > while only holding the pag_ici_lock in read mode so we can race with > xfs_reclaim_inodes_ag(). Looks like xfs_reclaim_inodes_ag() will do the > right thing anyway so just remove the assert. > > Thanks to Christoph for pointing out where the problem was. Yeah, given that I ran with this patch for a while you have my ACK for it. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Remove unused variable in ktrace_free(), Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH] Check return value of xfs_buf_get_noaddr(), Christoph Hellwig |
| Previous by Thread: | [PATCH] Remove unnecessary assertion, Lachlan McIlroy |
| Next by Thread: | next-20081203 build failure, when building xfs_file.o, Kamalesh Babulal |
| Indexes: | [Date] [Thread] [Top] [All Lists] |