| To: | Lachlan McIlroy <lachlan@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] Use the incore inode size in xfs_file_readdir() |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Thu, 4 Dec 2008 02:08:27 -0500 |
| Cc: | xfs-oss <xfs@xxxxxxxxxxx> |
| In-reply-to: | <49377FBC.5020501@sgi.com> |
| References: | <49377FBC.5020501@sgi.com> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Thu, Dec 04, 2008 at 05:59:08PM +1100, Lachlan McIlroy wrote: > We should be using the incore inode size here not the linux inode > size. The incore inode size is always up to date for directories > whereas the linux inode size is not updated for directories. > > We've hit assertions in xfs_bmap() and traced it back to the linux > inode size being zero here but the incore size being correct. Heh. Looks good, but you can still call ->readdir with a 0 inode size, so you might want to check for that (actualyl I think other pathes are goign to take care of it, but..) |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Fix bug in xlogitm idbg command, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH] Remove unused variable in ktrace_free(), Christoph Hellwig |
| Previous by Thread: | [PATCH] Use the incore inode size in xfs_file_readdir(), Lachlan McIlroy |
| Next by Thread: | Re: [PATCH] Use the incore inode size in xfs_file_readdir(), Lachlan McIlroy |
| Indexes: | [Date] [Thread] [Top] [All Lists] |