xfs
[Top] [All Lists]

Re: Assertion failed: atomic_read(&mp->m_active_trans)

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Lachlan McIlroy <lachlan@xxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: Assertion failed: atomic_read(&mp->m_active_trans)
From: Donald Douwsma <donaldd@xxxxxxx>
Date: Thu, 04 Dec 2008 16:36:43 +1100
In-reply-to: <20081203213950.GX18236@disturbed>
References: <492BB095.1000104@sgi.com> <4934AAA9.5090405@sgi.com> <20081203104849.GF15485@infradead.org> <20081203213950.GX18236@disturbed>
User-agent: Thunderbird 2.0.0.18 (X11/20081125)
Dave Chinner wrote:
> On Wed, Dec 03, 2008 at 05:48:49AM -0500, Christoph Hellwig wrote:
>> I'd rather fix it properly.
> 
> Sure, but in the mean time, I'd suggest changing it to a WARN_ON()
> rather than an ASSERT(). That way we'll continue to have ppl bug us
> about it until the VFS can support read-only remounts without racing
> correctly.

That sounds like a much better idea.

Unfortunately we wont get feedback when people hit this on the root fs
unless they have serial consoles (since /var/log/... has gone away by then).

> Has that work been dropped on the floor, Christoph? We'vecat 
> been holding off removing this ASSERT or adding the hack
> I did to work around the common case of the assert triggering
> based on the fact that the problem in the VFS would be fixed
> in the next release. That was the case each release since
> 2.6.25 and there doesn't seem to be much progress...
> 
>> Do you guys have a somewhat reliable
>> testcase hitting it?
> 
> I used to have one of the xfsqa tests hit it every so often,
> but not what you'd call reliably....

Indeed, we dont hit this in regular qa. I guess most qa scripts dont
specifically exercise remount readonly wile stressing the filesystem.
The few occasions we have hit it were when rebooting in between test
runs when the root fs was xfs.

Don





--- a/fs/xfs/linux-2.6/xfs_sync.c
+++ b/fs/xfs/linux-2.6/xfs_sync.c
@@ -371,7 +371,7 @@ xfs_quiesce_attr(
        /* flush inodes and push all remaining buffers out to disk */
        xfs_quiesce_fs(mp);
 
-       ASSERT_ALWAYS(atomic_read(&mp->m_active_trans) == 0);
+       WARN_ON(atomic_read(&mp->m_active_trans) == 0);
 
        /* Push the superblock and write an unmount record */
        error = xfs_log_sbcount(mp, 1);

<Prev in Thread] Current Thread [Next in Thread>