Re: [patch 20/22] move vn_iowait / vn_iowake into xfs

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [patch 20/22] move vn_iowait / vn_iowake into xfs_aops.c
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Wed, 3 Dec 2008 14:17:19 +1100
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20081202160652.542003000@bombadil.infradead.org>
Mail-followup-to:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References:	<20081202160430.775774000@bombadil.infradead.org> <20081202160652.542003000@bombadil.infradead.org>
User-agent:	Mutt/1.5.18 (2008-05-17)

On Tue, Dec 02, 2008 at 11:04:50AM -0500, Christoph Hellwig wrote:
> The whole machinery to wait on I/O completion is related to the I/O path
> and should be there instead of in xfs_vnode.c.  Also give the functions
> more descriptive names.

I'm not sure that "xfs_ioend_..." is the best name - it looks
slightly weird in some of the callers' contexts. Just dropping the
"end" out of the names makes the code read much better (i.e.
xfs_io_wait() and xfs_io_wake()). Not particularly important,
though, and everything else looks good.

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [patch 05/22] cleanup the inode reclaim path, (continued) Re: [patch 05/22] cleanup the inode reclaim path, Christoph Hellwig [patch 02/22] remove useless mnt_want_write call in xfs_write, Christoph Hellwig Re: [patch 02/22] remove useless mnt_want_write call in xfs_write, Dave Chinner [patch 17/22] no explicit xfs_iflush for special inodes during unmount, Christoph Hellwig Re: [patch 17/22] no explicit xfs_iflush for special inodes during unmount, Dave Chinner [patch 19/22] kill vn_ioerror, Christoph Hellwig Re: [patch 19/22] kill vn_ioerror, Dave Chinner [patch 18/22] kill xfs_unmount_flush, Christoph Hellwig Re: [patch 18/22] kill xfs_unmount_flush, Dave Chinner [patch 20/22] move vn_iowait / vn_iowake into xfs_aops.c, Christoph Hellwig Re: [patch 20/22] move vn_iowait / vn_iowake into xfs_aops.c, Dave Chinner <= Re: [patch 20/22] move vn_iowait / vn_iowake into xfs_aops.c, Christoph Hellwig Re: [patch 20/22] move vn_iowait / vn_iowake into xfs_aops.c, Dave Chinner [patch 04/22] remove unused prototypes for xfs_ihash_init / xfs_ihash_free, Christoph Hellwig Re: [patch 04/22] remove unused prototypes for xfs_ihash_init / xfs_ihash_free, Dave Chinner Re: [patch 04/22] remove unused prototypes for xfs_ihash_init / xfs_ihash_free, Eric Sandeen [patch 09/22] remove dead code from sv_t implementation, Christoph Hellwig Re: [patch 09/22] remove dead code from sv_t implementation, Dave Chinner [patch 10/22] kill dead quota flags, Christoph Hellwig Re: [patch 10/22] kill dead quota flags, Dave Chinner [patch 22/22] use inode_change_ok for setattr permission checking, Christoph Hellwig

Previous by Date:	Re: [patch 19/22] kill vn_ioerror, Dave Chinner
Next by Date:	Re: Disk full during delayed allocation, Dave Chinner
Previous by Thread:	[patch 20/22] move vn_iowait / vn_iowake into xfs_aops.c, Christoph Hellwig
Next by Thread:	Re: [patch 20/22] move vn_iowait / vn_iowake into xfs_aops.c, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]

Re: [patch 20/22] move vn_iowait / vn_iowake into xfs_aops.c