| To: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [patch 17/22] no explicit xfs_iflush for special inodes during unmount |
| From: | Dave Chinner <david@xxxxxxxxxxxxx> |
| Date: | Wed, 3 Dec 2008 14:06:29 +1100 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <20081202160651.992698000@bombadil.infradead.org> |
| Mail-followup-to: | Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx |
| References: | <20081202160430.775774000@bombadil.infradead.org> <20081202160651.992698000@bombadil.infradead.org> |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
On Tue, Dec 02, 2008 at 11:04:47AM -0500, Christoph Hellwig wrote: > Currently we explicitly call xfs_iflush on the quota, real-time and root > inodes from xfs_unmount_flush. But we just called xfs_sync_inodes with > SYNC_ATTR and do an XFS_bflush aka xfs_flush_buftarg to make sure all inodes > are on disk already, so there is no need for these special cases. > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx |
| Previous by Date: | Re: [patch 09/22] remove dead code from sv_t implementation, Dave Chinner |
|---|---|
| Next by Date: | Re: [patch 14/22] remove leftovers of shared read-only support, Dave Chinner |
| Previous by Thread: | [patch 17/22] no explicit xfs_iflush for special inodes during unmount, Christoph Hellwig |
| Next by Thread: | [patch 19/22] kill vn_ioerror, Christoph Hellwig |
| Indexes: | [Date] [Thread] [Top] [All Lists] |