Re: [patch 06/22] kill xfs_buf

xfs

Re: [patch 06/22] kill xfs_buf_iostart

To:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject:	Re: [patch 06/22] kill xfs_buf_iostart
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Wed, 3 Dec 2008 13:37:54 +1100
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<20081202160650.360918000@bombadil.infradead.org>
Mail-followup-to:	Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References:	<20081202160430.775774000@bombadil.infradead.org> <20081202160650.360918000@bombadil.infradead.org>
User-agent:	Mutt/1.5.18 (2008-05-17)

On Tue, Dec 02, 2008 at 11:04:36AM -0500, Christoph Hellwig wrote:
> xfs_buf_iostart is a "shared" helper for xfs_buf_read_flags,
> xfs_bawrite, and xfs_bdwrite - except that there isn't much shared
> code but rather special cases for each caller.
> 
> So remove this function and move the functionality to the caller.
> xfs_bawrite and xfs_bdwrite are now big enough to be moved out of
> line and the xfs_buf_read_flags is moved into a new helper called
> _xfs_buf_read.
> 
> (First sent on August 2nd)
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[patch 08/22] reduce l_icloglock roundtrips, (continued) [patch 08/22] reduce l_icloglock roundtrips, Christoph Hellwig Re: [patch 08/22] reduce l_icloglock roundtrips, Dave Chinner Re: [patch 08/22] reduce l_icloglock roundtrips, Christoph Hellwig [patch 12/22] kill dead inode flags, Christoph Hellwig Re: [patch 12/22] kill dead inode flags, Dave Chinner Re: [patch 12/22] kill dead inode flags, Niv Sardi Re: [patch 12/22] kill dead inode flags, Christoph Hellwig [patch 03/22] remove unused behvavior cruft in xfs_super.h, Christoph Hellwig Re: [patch 03/22] remove unused behvavior cruft in xfs_super.h, Dave Chinner [patch 06/22] kill xfs_buf_iostart, Christoph Hellwig Re: [patch 06/22] kill xfs_buf_iostart, Dave Chinner <= [patch 07/22] stop using igrab in xfs_vn_link, Christoph Hellwig Re: [patch 07/22] stop using igrab in xfs_vn_link, Dave Chinner [patch 13/22] remove unused m_inode_quiesce member from struct xfs_mount, Christoph Hellwig Re: [patch 13/22] remove unused m_inode_quiesce member from struct xfs_mount, Dave Chinner [patch 21/22] move inode tracing out of xfs_vnode., Christoph Hellwig Re: [patch 21/22] move inode tracing out of xfs_vnode., Dave Chinner Re: [patch 00/22] 2.6.29 queue, Christoph Hellwig

Previous by Date:	Re: [patch 05/22] cleanup the inode reclaim path, Dave Chinner
Next by Date:	Re: [patch 07/22] stop using igrab in xfs_vn_link, Dave Chinner
Previous by Thread:	[patch 06/22] kill xfs_buf_iostart, Christoph Hellwig
Next by Thread:	[patch 07/22] stop using igrab in xfs_vn_link, Christoph Hellwig
Indexes:	[Date] [Thread] [Top] [All Lists]