xfs
[Top] [All Lists]

[XFS updates] XFS development tree branch, master, updated. v2.6.28-rc3-

To: xfs@xxxxxxxxxxx
Subject: [XFS updates] XFS development tree branch, master, updated. v2.6.28-rc3-1082-ge5d412f
From: xfs@xxxxxxxxxxx
Date: Tue, 2 Dec 2008 00:33:21 -0600
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "XFS development tree".

The branch, master has been updated
  e5d412f [XFS] Reorder xfs_ioctl32.c for some tidiness
  710d62a [XFS] Hook up compat XFS_IOC_FSSETDM_BY_HANDLE ioctl handler
  2875097 [XFS] Hook up compat XFS_IOC_ATTRMULTI_BY_HANDLE ioctl handler
  ebeecd2 [XFS] Hook up compat XFS_IOC_ATTRLIST_BY_HANDLE ioctl handler
  af819d2 [XFS] Fix compat XFS_IOC_FSBULKSTAT_SINGLE ioctl
  65fbaf2 [XFS] Fix xfs_bulkstat_one size checks & error handling
  2ee4fa5 [XFS] Make the bulkstat_one compat ioctl handling more sane
  471d591 [XFS] Add compat handlers for data & rt growfs ioctls
  e94fc4a [XFS] Add compat handlers for swapext ioctl
  d5547f9 [XFS] Clean up some existing compat ioctl calls
  ffae263 [XFS] Move compat ioctl structs & numbers into xfs_ioctl32.h
  743bb46 [XFS] Move copy_from_user calls out of ioctl helpers into ioctl 
switch.
      from  0e446673a15a4e9c336b67c1a638eb12c21d0993 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e5d412f17846b0aea9e5250926f994ab2e4e1006
Author: sandeen@xxxxxxxxxxx <sandeen@xxxxxxxxxxx>
Date:   Tue Nov 25 21:20:17 2008 -0600

    [XFS] Reorder xfs_ioctl32.c for some tidiness
    
    Put things in IMHO a more readable order, now
    that it's all done; add some comments.
    
    Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
    Reviewed-by: Christoph Hellwig <hch@xxxxxx>
    Signed-off-by: Lachlan McIlroy <lachlan@xxxxxxx>

commit 710d62aaaf17c841b8bdbc7a775f8910a7160248
Author: sandeen@xxxxxxxxxxx <sandeen@xxxxxxxxxxx>
Date:   Tue Nov 25 21:20:16 2008 -0600

    [XFS] Hook up compat XFS_IOC_FSSETDM_BY_HANDLE ioctl handler
    
    Add a compat handler for XFS_IOC_FSSETDM_BY_HANDLE.
    
    I haven't tested this, lacking dmapi tools to do so
    (unless xfsqa magically gets this somehow?)
    
    Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
    Reviewed-by: Christoph Hellwig <hch@xxxxxx>
    Signed-off-by: Lachlan McIlroy <lachlan@xxxxxxx>

commit 28750975ace79c547407a84d3969cbed516be8f8
Author: sandeen@xxxxxxxxxxx <sandeen@xxxxxxxxxxx>
Date:   Tue Nov 25 21:20:15 2008 -0600

    [XFS] Hook up compat XFS_IOC_ATTRMULTI_BY_HANDLE ioctl handler
    
    Add a compat handler for XFS_IOC_ATTRMULTI_BY_HANDLE
    
    Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
    Reviewed-by: Christoph Hellwig <hch@xxxxxx>
    Signed-off-by: Lachlan McIlroy <lachlan@xxxxxxx>

commit ebeecd2b04645a4b79e1bc00d69cf4f98e03a684
Author: sandeen@xxxxxxxxxxx <sandeen@xxxxxxxxxxx>
Date:   Tue Nov 25 21:20:14 2008 -0600

    [XFS] Hook up compat XFS_IOC_ATTRLIST_BY_HANDLE ioctl handler
    
    Add a compat handler for XFS_IOC_ATTRLIST_BY_HANDLE
    
    Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
    Reviewed-by: Christoph Hellwig <hch@xxxxxx>
    Signed-off-by: Lachlan McIlroy <lachlan@xxxxxxx>

commit af819d27637119105213433881f158931e29620b
Author: sandeen@xxxxxxxxxxx <sandeen@xxxxxxxxxxx>
Date:   Tue Nov 25 21:20:13 2008 -0600

    [XFS] Fix compat XFS_IOC_FSBULKSTAT_SINGLE ioctl
    
    The XFS_IOC_FSBULKSTAT_SINGLE ioctl passes in the
    desired inode number, while XFS_IOC_FSBULKSTAT passes
    in the previous/last-stat'd inode number.  The
    compat handler wasn't differentiating these, so
    when a XFS_IOC_FSBULKSTAT_SINGLE request for inode
    128 was sent in, stat information for 131 was sent out.
    
    Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
    Reviewed-by: Christoph Hellwig <hch@xxxxxx>
    Signed-off-by: Lachlan McIlroy <lachlan@xxxxxxx>

commit 65fbaf2489c667bf79ae1f20403f30c66568d445
Author: sandeen@xxxxxxxxxxx <sandeen@xxxxxxxxxxx>
Date:   Tue Nov 25 21:20:12 2008 -0600

    [XFS] Fix xfs_bulkstat_one size checks & error handling
    
    The 32-bit xfs_blkstat_one handler was failing because
    a size check checked whether the remaining (32-bit)
    user buffer was less than the (64-bit) bulkstat buffer,
    and failed with ENOMEM if so.  Move this check
    into the respective handlers so that they check the
    correct sizes.
    
    Also, the formatters were returning negative errors
    or positive bytes copied; this was odd in the positive
    error value world of xfs, and handled wrong by at least
    some of the callers, which treated the bytes returned
    as an error value.  Move the bytes-used assignment
    into the formatters.
    
    Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
    Reviewed-by: Christoph Hellwig <hch@xxxxxx>
    Signed-off-by: Lachlan McIlroy <lachlan@xxxxxxx>

commit 2ee4fa5cb716eba104a4ef8efe159e1007a2aef6
Author: sandeen@xxxxxxxxxxx <sandeen@xxxxxxxxxxx>
Date:   Tue Nov 25 21:20:11 2008 -0600

    [XFS] Make the bulkstat_one compat ioctl handling more sane
    
    Currently the compat formatter was handled by passing
    in "private_data" for the xfs_bulkstat_one formatter,
    which was really just another formatter... IMHO this
    got confusing.
    
    Instead, just make a new xfs_bulkstat_one_compat
    formatter for xfs_bulkstat, and call it via a wrapper.
    
    Also, don't translate the ioctl nrs into their native
    counterparts, that just clouds the issue; we're in a
    compat handler anyway, just switch on the 32-bit cmds.
    
    Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
    Reviewed-by: Christoph Hellwig <hch@xxxxxx>
    Signed-off-by: Lachlan McIlroy <lachlan@xxxxxxx>

commit 471d59103167c84f17b9bcfee22ed10b44ff206e
Author: sandeen@xxxxxxxxxxx <sandeen@xxxxxxxxxxx>
Date:   Tue Nov 25 21:20:10 2008 -0600

    [XFS] Add compat handlers for data & rt growfs ioctls
    
    The args for XFS_IOC_FSGROWFSDATA and XFS_IOC_FSGROWFSRTA
    have padding on the end on intel, so add arg copyin functions,
    and then just call the growfs ioctl helpers.
    
    Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
    Reviewed-by: Christoph Hellwig <hch@xxxxxx>
    Signed-off-by: Lachlan McIlroy <lachlan@xxxxxxx>

commit e94fc4a43e5c39f689e83caf6d2f0939081f5e6b
Author: sandeen@xxxxxxxxxxx <sandeen@xxxxxxxxxxx>
Date:   Tue Nov 25 21:20:09 2008 -0600

    [XFS] Add compat handlers for swapext ioctl
    
    The big hitter here was the bstat field, which contains
    different sized time_t on 32 vs. 64 bit.  Add a copyin
    function to translate the 32-bit arg to 64-bit, and
    call the swapext ioctl helper.
    
    Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
    Reviewed-by: Christoph Hellwig <hch@xxxxxx>
    Signed-off-by: Lachlan McIlroy <lachlan@xxxxxxx>

commit d5547f9feea459dfc9e7313bd1d561394e2c129f
Author: sandeen@xxxxxxxxxxx <sandeen@xxxxxxxxxxx>
Date:   Tue Nov 25 21:20:08 2008 -0600

    [XFS] Clean up some existing compat ioctl calls
    
    Create a new xfs_ioctl.h file which has prototypes for
    ioctl helpers that may be called in compat mode.
    
    Change several compat ioctl cases which are IOW to simply copy
    in the userspace argument, then call the common ioctl helper.
    
    This also fixes xfs_compat_ioc_fsgeometry_v1(), which had
    it backwards before; it copied in an (empty) arg, then copied
    out the native result, which probably corrupted userspace.  It
    should be translating on the copyout.
    
    Also, a bit of formatting cleanup for consistency, and conversion
    of all error returns to use XFS_ERROR().
    
    Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
    Reviewed-by: Christoph Hellwig <hch@xxxxxx>
    Signed-off-by: Lachlan McIlroy <lachlan@xxxxxxx>

commit ffae263a640b736a7206a0d7bd14ab44eb58cd28
Author: sandeen@xxxxxxxxxxx <sandeen@xxxxxxxxxxx>
Date:   Tue Nov 25 21:20:07 2008 -0600

    [XFS] Move compat ioctl structs & numbers into xfs_ioctl32.h
    
    This makes the c file less cluttered and a bit more
    readable.   Consistently name the ioctl number
    macros with "_32" and the compatibility stuctures
    with "_compat."  Rename the helpers which simply
    copy in the arg with "_copyin" for easy identification.
    
    Finally, for a few of the existing helpers, modify them
    so that they directly call the native ioctl helper
    after userspace argument fixup.
    
    Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
    Reviewed-by: Christoph Hellwig <hch@xxxxxx>
    Signed-off-by: Lachlan McIlroy <lachlan@xxxxxxx>

commit 743bb4650da9e2595d6cedd01c680b5b9398c74a
Author: sandeen@xxxxxxxxxxx <sandeen@xxxxxxxxxxx>
Date:   Tue Nov 25 21:20:06 2008 -0600

    [XFS] Move copy_from_user calls out of ioctl helpers into ioctl switch.
    
    Moving the copy_from_user out of some of the ioctl helpers will
    make it easier for the compat ioctl switch to copy in the right
    struct, then just pass to the underlying helper.
    
    Also, move common access checks into the helpers themselves,
    and out of the native ioctl switch code, to reduce code
    duplication between native & compat ioctl callers.
    
    Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
    Reviewed-by: Christoph Hellwig <hch@xxxxxx>
    Signed-off-by: Lachlan McIlroy <lachlan@xxxxxxx>

-----------------------------------------------------------------------

Summary of changes:
 fs/xfs/linux-2.6/xfs_ioctl.c   |  123 +++---
 fs/xfs/linux-2.6/xfs_ioctl.h   |   70 ++++
 fs/xfs/linux-2.6/xfs_ioctl32.c |  838 ++++++++++++++++++++++++++--------------
 fs/xfs/linux-2.6/xfs_ioctl32.h |  213 ++++++++++
 fs/xfs/xfs_dfrag.c             |    8 +-
 fs/xfs/xfs_dfrag.h             |    2 +-
 fs/xfs/xfs_fs.h                |    4 -
 fs/xfs/xfs_fsops.c             |    6 +
 fs/xfs/xfs_itable.c            |   45 ++-
 fs/xfs/xfs_itable.h            |   14 +
 fs/xfs/xfs_rtalloc.c           |    2 +
 11 files changed, 955 insertions(+), 370 deletions(-)
 create mode 100644 fs/xfs/linux-2.6/xfs_ioctl.h


hooks/post-receive
-- 
XFS development tree

<Prev in Thread] Current Thread [Next in Thread>
  • [XFS updates] XFS development tree branch, master, updated. v2.6.28-rc3-1082-ge5d412f, xfs <=