xfs
[Top] [All Lists]

Re: [XFS updates] XFS public tree - master for latest XFS changes...

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [XFS updates] XFS public tree - master for latest XFS changes...
From: Timothy Shimmin <tes@xxxxxxx>
Date: Tue, 02 Dec 2008 14:54:40 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20081201064949.GL6291@disturbed>
References: <200812010015.mB10F1Ab031727@oss.sgi.com> <20081201064949.GL6291@disturbed>
User-agent: Thunderbird 2.0.0.17 (Macintosh/20080914)
Dave Chinner wrote:
> On Sun, Nov 30, 2008 at 06:15:01PM -0600, Niv Sardi wrote:
>> - Log -----------------------------------------------------------------
>> commit 0924b585fc49bf371bc700c23e516a538bf589af
>> Author: Dave Chinner <david@xxxxxxxxxxxxx>
>> Date:   Fri Nov 28 14:23:34 2008 +1100
>>
>>     [XFS] fix uninitialised variable bug in dquot release.
>>     
>>     gcc is warning about an uninitialised variable in xfs_growfs_rt().
>>     This is a false positive. Fix it by changing the scope of the
>>     transaction pointer to wholly within the internal loop inside
>>     the function.
> 
> The title of that doesn't match the description. I think it
> was supposed to be:
> 
> [PATCH 4/5] XFS: fix spurious uninitialised variable warning in xfs_growfs_rt
> 
> BTW, can we get a one-line summary of the commits being referenced
> in the message? 

Yes.
The list of commits at the start now has the 1st line of each commit 
description.

--Tim

<Prev in Thread] Current Thread [Next in Thread>