On Fri, Sep 26, 2008 at 12:56:13AM +0200, Christoph Hellwig wrote:
| Here's an updated crc series for various metadata structures. We're still
| looking at the magic number in the log recovery case because getting down
| a buffer type for the other structures wasn't quite as easy as for the
| btree block. I'll probably look into that again once we're done with all
| data structures.
I've carried out cursory build and test of this series. I'm concerned that
my testing (and anyone else's testing) has not addressed performance hits
being introduced with crc on metadata. What level of testing have you done,
and can you recommend some testing that goes beyond the QA suite that we
have in place. I did run the btree test harness on that earlier series, but it
appeared to me that that was a go/no-go test and unless I'm missing something,
I've not seen tests that might help quantify performance hits.