xfs
[Top] [All Lists]

Re: [patch 01/12] Move copy_from_user calls out of ioctl helpers into io

To: sandeen@xxxxxxxxxxx
Subject: Re: [patch 01/12] Move copy_from_user calls out of ioctl helpers into ioctl switch.
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 26 Nov 2008 05:03:39 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20081126032026.775790208@xxxxxxxxxxx>
References: <20081126032005.639750968@xxxxxxxxxxx> <20081126032026.775790208@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Nov 25, 2008 at 09:20:06PM -0600, sandeen@xxxxxxxxxxx wrote:
> Moving the copy_from_user out of some of the ioctl helpers will
> make it easier for the compat ioctl switch to copy in the right
> struct, then just pass to the underlying helper.
> 
> Also, move common access checks into the helpers themselves,
> and out of the native ioctl switch code, to reduce code
> duplication between native & compat ioctl callers.

Looks good.

<Prev in Thread] Current Thread [Next in Thread>