xfs
[Top] [All Lists]

Re: [PATCH] xfsdump: don't redeclare offsetoff

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfsdump: don't redeclare offsetoff
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Tue, 25 Nov 2008 10:01:01 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20081125105519.GA21288@xxxxxxxxxxxxx>
References: <20081125105519.GA21288@xxxxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.16 (X11/20080723)
Christoph Hellwig wrote:
> Don't redeclare offsetof, we already include <stddef.h> to get it and
> modern gcc will complain about the redeclaration.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Index: xfs-cmds/xfsdump/common/getdents.c
> ===================================================================
> --- xfs-cmds.orig/xfsdump/common/getdents.c   2008-11-13 18:45:11.000000000 
> +0100
> +++ xfs-cmds/xfsdump/common/getdents.c        2008-11-13 18:45:18.000000000 
> +0100
> @@ -72,8 +72,6 @@ extern int __have_no_getdents64;
>  # endif
>  #endif
>  
> -#define offsetof(TYPE, MEMBER) ((size_t) &((TYPE *)0)->MEMBER)
> -

ACK.  I'd noticed this too, thanks.

-Eric

<Prev in Thread] Current Thread [Next in Thread>