xfs
[Top] [All Lists]

Re: [patch 05/11] Make the bulkstat_one compat ioctl handling more sane

To: sandeen@xxxxxxxxxxx
Subject: Re: [patch 05/11] Make the bulkstat_one compat ioctl handling more sane
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 19 Nov 2008 10:09:31 -0500
Cc: xfs@xxxxxxxxxxx, hch@xxxxxxxxxxxxx
In-reply-to: <20081119044909.365709806@xxxxxxxxxxx>
References: <20081119044401.573365619@xxxxxxxxxxx> <20081119044909.365709806@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Nov 18, 2008 at 10:44:06PM -0600, sandeen@xxxxxxxxxxx wrote:
> Currently the compat formatter was handled by passing
> in "private_data" for the xfs_bulkstat_one formatter,
> which was really just another formatter... IMHO this
> got confusing.
> 
> Instead, just make a new xfs_bulkstat_one_compat
> formatter for xfs_bulkstat, and call it via a wrapper.
> 
> Also, don't translate the ioctl nrs into their native
> counterparts, that just clouds the issue; we're in a
> compat handler anyway, just switch on the 32-bit cmds.

Looks good.

<Prev in Thread] Current Thread [Next in Thread>