xfs
[Top] [All Lists]

Re: [patch 04/11] Add compat handlers for swapext ioctl

To: sandeen@xxxxxxxxxxx
Subject: Re: [patch 04/11] Add compat handlers for swapext ioctl
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 19 Nov 2008 10:08:36 -0500
Cc: xfs@xxxxxxxxxxx, hch@xxxxxxxxxxxxx
In-reply-to: <20081119044908.948703484@xxxxxxxxxxx>
References: <20081119044401.573365619@xxxxxxxxxxx> <20081119044908.948703484@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Nov 18, 2008 at 10:44:05PM -0600, sandeen@xxxxxxxxxxx wrote:
> The big hitter here was the bstat field, which contains
> different sized time_t on 32 vs. 64 bit.  Add a copyin
> function to translate the 32-bit arg to 64-bit, and
> call the native ioctl.

Same argument as in most previous patches about calling into the
low-level handler directly.  Although xfs_swapext will need some changes
to move the copy_from_user into the caller for that.

<Prev in Thread] Current Thread [Next in Thread>