xfs
[Top] [All Lists]

Re: [PATCH 2/3 v4] Add new flags to getbmapx interface

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 2/3 v4] Add new flags to getbmapx interface
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 12 Nov 2008 04:22:36 -0500
Cc: xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <49089644.8070402@xxxxxxxxxxx>
References: <49089596.80006@xxxxxxxxxxx> <49089644.8070402@xxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Wed, Oct 29, 2008 at 11:58:44AM -0500, Eric Sandeen wrote:
> Add new getbmap flags.
> 
> This adds a new output flag, BMV_OF_LAST to indicate if we've hit
> the last extent in the inode.  This potentially saves an extra call
> from userspace to see when the whole mapping is done.
> 
> It also adds BMV_IF_DELALLOC and BMV_OF_DELALLOC to request, and
> indicate, delayed-allocation extents.  In this case bmv_block
> is set to -2 (-1 was already taken for HOLESTARTBLOCK; unfortunately
> these are the reverse of the in-kernel constants.)
> 
> These new flags facilitate addition of the new fiemap interface.
> 
> Rather than adding sh_delalloc, remove sh_unwritten & just test
> the flags directly.

Looks good.

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 2/3 v4] Add new flags to getbmapx interface, Christoph Hellwig <=