xfs
[Top] [All Lists]

Re: [PATCH 1/5] XFS: fix error inversion problems with data flushing

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
Subject: Re: [PATCH 1/5] XFS: fix error inversion problems with data flushing
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 6 Nov 2008 10:39:49 -0500
In-reply-to: <20081102225133.GI19509@disturbed>
References: <1225415729-26514-1-git-send-email-david@xxxxxxxxxxxxx> <1225415729-26514-2-git-send-email-david@xxxxxxxxxxxxx> <20081031201830.GA20309@xxxxxxxxxxxxx> <20081102225133.GI19509@disturbed>
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Nov 03, 2008 at 09:51:33AM +1100, Dave Chinner wrote:
> Yes, that's the point of the patch - we get it wrong in many
> places and this fixes them so that correctly signed error values
> are returned to the higher layers....

Well, you also introduce xfs_wait_on_pages, which should at least be
documented.  And I'd have to say I don't really like adding more of
these wrappers just for the sake of it.

<Prev in Thread] Current Thread [Next in Thread>