xfs
[Top] [All Lists]

Re: [PATCH] fix xfsqa test 052 filtering with long device names

To: xfs mailing list <xfs@xxxxxxxxxxx>
Subject: Re: [PATCH] fix xfsqa test 052 filtering with long device names
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 05 Nov 2008 16:41:50 -0600
In-reply-to: <46CF6919.2050404@xxxxxxxxxxx>
References: <46CF6919.2050404@xxxxxxxxxxx>
User-agent: Thunderbird 2.0.0.16 (X11/20080723)
This is still a problem and I just wasted too much time on it
before I remembered the cause ... can we merge this please so
I don't hit it again next year?  :)

Thanks,
-Eric

-------------------------

Long devicenames cause this quota output to split onto 2 lines:

# xfs_quota -c "quota -gpu -birnN 99" /mnt/scratch
/dev/mapper/testvol-test2
                           880       1004       1004   00 [--------]           
1         10         10   00 [--------]           0          0          0   00 
[--------] /mnt/scratch

but if we make that "\n" go away, the test still passes.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

Index: xfs-cmds/xfstests/052
===================================================================
--- xfs-cmds.orig/xfstests/052
+++ xfs-cmds/xfstests/052
@@ -82,8 +82,8 @@ xfs_quota -x \
 
 # cross check blks, softblks, hardblks <-> quota, xfs_db
 xfs_quota -c "quota -$type -birnN $id" $SCRATCH_DEV |
-                       tr -s '[:space:]' | tee -a $seq.full | perl -ne '
-       if (m[^\s*'$SCRATCH_DEV'\s+(\d+)\s+(\d+)\s+(\d+)]) {
+                       tr -d '\n' | tr -s '[:space:]' | tee -a $seq.full |
+       perl -ne 'if (m[^\s*'$SCRATCH_DEV'\s+(\d+)\s+(\d+)\s+(\d+)]) {
                print "used_blocks=", $1, "\n";
                print "soft_blocks=", $2, "\n";
                print "hard_blocks=", $3, "\n";



<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH] fix xfsqa test 052 filtering with long device names, Eric Sandeen <=