xfs
[Top] [All Lists]

Re: [PATCH 2/6] remove dead code for old inode item recovery

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/6] remove dead code for old inode item recovery
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 3 Nov 2008 11:47:12 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20081027134122.GC3183@xxxxxxxxxxxxx>
Mail-followup-to: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <20081027134122.GC3183@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Mon, Oct 27, 2008 at 09:41:22AM -0400, Christoph Hellwig wrote:
> We have removed the support for old-style inode items a while ago and
> xlog_recover_do_inode_trans is now only called for XFS_LI_INODE items.
> That means we can remove the call to xfs_imap there and with it the
> XFS_IMAP_LOOKUP that is set by all other callers.  We can also mark
> xfs_imap static now.
> 
> (First sent on October 21st)
> 
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Dave Chinner <david@xxxxxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 2/6] remove dead code for old inode item recovery, Dave Chinner <=