[Top] [All Lists]

Re: [PATCH 0/2] Urgent queue

To: Mark Goodwin <markgw@xxxxxxx>
Subject: Re: [PATCH 0/2] Urgent queue
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Mon, 3 Nov 2008 11:43:23 +1100
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <4906EB5B.2020004@xxxxxxx>
Mail-followup-to: Mark Goodwin <markgw@xxxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
References: <20081027133010.GA30607@xxxxxxxxxxxxx> <20081028064150.GS4985@disturbed> <4906EB5B.2020004@xxxxxxx>
User-agent: Mutt/1.5.18 (2008-05-17)
On Tue, Oct 28, 2008 at 09:37:15PM +1100, Mark Goodwin wrote:
> Dave Chinner wrote:
>> On Mon, Oct 27, 2008 at 09:30:10AM -0400, Christoph Hellwig wrote:
>>> Two patches that are small bugfixes / features that are what I consider the
>>> immediately merge queue.
>> The entire set of 30 patches has passed XFSQA on my test box....
> individually (by series) or only after all 30? Bisectability is important,
> as Christoph alluded to in another thread.

All - there is no way in hell I'm going to run qa on each patch
individually given that most of them are trivial.

Bisectability is mainly about ensuring each patch builds
independently and at least runs without obvious problems.
Given most of the patches were independent, running QA over the
end series is usually sufficient to check that they will run
sufficiently well to do a bisect if they build.

That being said, given that I *have bisected* that series (to find
the directory corruption problem as a result of upgrading the
underlying kernel), I'd say it's just fine.

> Is the intention to try and take
> this lot for 28-rc3?

Just the urgent ones, I think. The rest are 2.6.29 candidates but
they still should be checked in and merged into the master branch so
that we can test them well before the .29 merge window comes

> I think Lachlan is now very close to a pull req for
> .28, depending on his testing for the memleak and deadlock fixes - time
> is now getting pretty short :)

Given that 2.6.28-rc3 is now out, I have serious doubts that Linus
will take an update of this size. We've missed the merge window by
two weeks....


Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH 0/2] Urgent queue, Dave Chinner <=