xfs
[Top] [All Lists]

Re: [PATCH] xfstests: create tape group

To: Eric Sandeen <sandeen@xxxxxxxxxxx>, xfs-oss <xfs@xxxxxxxxxxx>
Subject: Re: [PATCH] xfstests: create tape group
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Sun, 02 Nov 2008 17:12:17 -0600
In-reply-to: <20081102220551.GG19509@disturbed>
References: <490C7CAC.2070902@xxxxxxxxxxx> <20081102220551.GG19509@disturbed>
User-agent: Thunderbird 2.0.0.17 (Macintosh/20080914)
Dave Chinner wrote:

> On Sat, Nov 01, 2008 at 10:58:36AM -0500, Eric Sandeen wrote:
>   
>> Create a tape group for anything which expects
>> to dump to tape (I guess this is a superset
>> of "remote" and a few others).
>>     
>
> Given that most ppl don't have tape drives, should these be left in
> the auto group now that they can easily be run by 'check -g tape'? I
> know I've never had a config to run them the *entire* time I've 
> personally run XFSQA...
>
> Cheers,
>
> Dave.
>   
Sounds like a plan.  We probably don't even know (?) if they run
well enough to be in the auto group?  Revised patch below:

-----------------

Create a tape group for anything which expects
to dump to tape (I guess this is a superset
of "remote" and a few others).  Also, remove
this from the auto group; most people won't have tapes
and -g tape is easy enough (per dchinner's suggestion).

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx>
---

Index: xfs-cmds/xfstests/group
===================================================================
--- xfs-cmds.orig/xfstests/group
+++ xfs-cmds/xfstests/group
@@ -35,6 +35,9 @@ v2log         tes@xxxxxxx
 # xfsdump, xfsrestore, xfsinvutil
 dump           tes@xxxxxxx ivanr@xxxxxxx
 
+# xfsdump, xfsrestore to tapes
+tape           tes@xxxxxxx ivanr@xxxxxxx
+
 # xfsdump, xfsrestore to remote tapes
 remote         tes@xxxxxxx ivanr@xxxxxxx
 
@@ -118,10 +121,10 @@ nfs4acl           tes@xxxxxxx donaldd@xxxxxxx
 019 mkfs auto
 020 metadata attr udf auto
 021 db attr auto
-022 dump ioctl auto
-023 dump ioctl auto
-024 dump ioctl auto
-025 dump ioctl auto
+022 dump ioctl tape
+023 dump ioctl tape
+024 dump ioctl tape
+025 dump ioctl tape
 026 dump ioctl auto
 027 dump ioctl auto
 028 dump ioctl auto
@@ -131,15 +134,15 @@ nfs4acl           tes@xxxxxxx donaldd@xxxxxxx
 032 mkfs auto
 033 repair auto
 034 other auto
-035 dump ioctl auto
-036 dump ioctl remote auto
-037 dump ioctl remote auto
-038 dump ioctl remote auto
-039 dump ioctl remote auto
+035 dump ioctl tape auto
+036 dump ioctl remote tape
+037 dump ioctl remote tape
+038 dump ioctl remote tape
+039 dump ioctl remote tape
 040 other auto
 041 growfs ioctl auto
 042 fsr ioctl auto
-043 dump ioctl auto
+043 dump ioctl tape
 044 other auto
 045 other auto
 046 dump ioctl auto
@@ -151,7 +154,7 @@ nfs4acl             tes@xxxxxxx donaldd@xxxxxxx
 052 quota db auto
 053 acl repair auto
 054 quota auto
-055 dump ioctl remote auto
+055 dump ioctl remote tape
 056 dump ioctl auto
 057 acl auto
 058 acl auto




<Prev in Thread] Current Thread [Next in Thread>